Skip to content

Conversation

@skyleo
Copy link
Contributor

@skyleo skyleo commented Oct 5, 2019

Pull Request Prelude

Changes Proposed

Fix aggressive ranged mobs not attacking from above a cliff,
such as WoE Archer Guardians from above towers or Orc Archers in gef_fild14.

Issues addressed: none?

@skyleo skyleo added type:bug Issue is a bug or describes an incorrect behavior that should be fixed component:mechanics Affecting the game mechanics in general status:code-review Awaiting code review severity:3-medium Issues with GM commands, script commands, and other commonly used features labels Oct 5, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

|| (is_standing && wpd.path_len > md->db->range2) //Standing monsters use range2, walking monsters use range3
|| (!is_standing && wpd.path_len > md->db->range3)) {
if (!check_distance_bl(&md->bl, bl, md->status.rhw.range)
|| !path->search_long(NULL, &md->bl, md->bl.m, md->bl.x, md->bl.y, bl->x, bl->y, CELL_CHKWALL))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is official way?
if not, probably better add option and disable it by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the cells are marked as snipable, a player with a bow could attack from there as well. As far as I'm concerned Archer Guardians in WoE were always able to shoot from their watch towers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn this bug existed since the dawn of woe. haha!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always thought it was map that blocking them from attacking from high grounds. lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me too @Emistry

@MishimaHaruna MishimaHaruna added this to the Release v2019.10.20 milestone Oct 18, 2019
@MishimaHaruna MishimaHaruna merged commit 436ae38 into HerculesWS:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:mechanics Affecting the game mechanics in general severity:3-medium Issues with GM commands, script commands, and other commonly used features status:code-review Awaiting code review type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants