Fixes status changes effect timer when relogging #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
guilherme-gm
commented
Oct 5, 2019
guilherme-gm
force-pushed
the
201910-fix-sc-times
branch
from
9b383f3 to
44e73c0
Compare
guilherme-gm
changed the title
guilherme-gm
force-pushed
the
201910-fix-sc-times
branch
from
44e73c0 to
f0d4eda
Compare
guilherme-gm
changed the title
guilherme-gm
force-pushed
the
201910-fix-sc-times
branch
from
f0d4eda to
0de5ad0
Compare
dastgirp
requested changes
Oct 6, 2019
guilherme-gm
force-pushed
the
201910-fix-sc-times
branch
from
0de5ad0 to
5390860
Compare
4144
approved these changes
Oct 7, 2019
- This allows clients to continue the "timer" display after you login again
guilherme-gm
force-pushed
the
201910-fix-sc-times
branch
from
5390860 to
9e59948
Compare
dastgirp
approved these changes
Oct 9, 2019
MishimaHaruna
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This Pull Request fixes the effect timer of status changes when user relogs. Currently we send the client the remaining time as both the total time and the remaining time, thus making the timer go back to "full". The changes in this PR adds a new column to
sc_datawith the total time so we can restore the timer as it was before logging out.I chose to make those "wrapper" functions around
status_change_startandclif_status_changebecause they already have lots of parameters and are used in many places, simply adding another parameter would require me to update lots of places with repeated information.Issues addressed:
Fixes #2018