Fixes close merchant vending #2555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some wrong checks that prevented the vend to be closed.
Contributor
|
This change is |
4144
reviewed
Oct 10, 2019
4144
approved these changes
Oct 11, 2019
dastgirp
added
component:core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This PR removes some checks that were preventing players to close their vending (from merchant skill). The issue was basically because we had a check that prevented a player in any trading state (including vending) to close it.
I also removed the check for a dead player, because the client itself allows that, and the same problem would happen.
Issues addressed:
Fixes #2554