Homunculus skill fixes #2556
Merged
Homunculus skill fixes #2556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes not being able to use Homunculus skills when having 90% overweight. This also fixes not being able to use Homunculus skills when the owner has low HP or SP, even though the Homunculus has enough HP or SP to use the skill.
It has a chance to roll for enemy and heal the enemy, While calculating the chance was correct, it was getting the enemy with battle->check_target. But unit->stop_attack has been called before in unit->skilluse_id2, making battle->check_target return NULL at that point, since it has no attack target anymore. So it defaulted to heal the Homunculus itself, instead of the enemy.
skyleo
added
type:bug
Contributor
|
This change is |
skyleo
added
severity:3-medium
4144
approved these changes
Oct 10, 2019
MishimaHaruna
approved these changes
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Fix Chaotic Blessings never healing the enemy.
Fix Homunculus skill failure message not displaying required items. (eg: Healing Hands from Lif)
Fix Homunculus skill requirements being put on owner as well.
Last change meant for example that currently if the owner of an homunculus doesn't have enough SP, the homunculus won't be able to use skills requiring SP, even though the Homunculus might have enough SP. This is now fixed with this change.
Note:
All of these fixes have been tested and are proven to work.
Issues addressed: None?