-
Notifications
You must be signed in to change notification settings - Fork 772
Make slave mobs react to master's chase target #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
better squash fixup commit with actual commits with changes. I mean better not create separate commits with compilation fixes |
Yes, those will be squashed, but for the review they're there atm, so people aren't confused by me rebasing and changing the history. |
|
@4144 We're assuming safely at a few places that the master is of type BL_MOB in mob->ai_sub_hard_slavemob in those changes. If you know of cases where this is not the case, please tell me so I can modify the changes. Also squashed everything reviewed so far, except for Removing trailing whitespace and a new suggestion that has been applied. |
887c0b9 to
f55481e
Compare
This fixes slaves not chasing after master's chase target, when master was immobilized by an Ankle Snare for example midway.
f55481e to
c0e2558
Compare
|
Squashed all that needed to be squashed ~ |
Pull Request Prelude
Changes Proposed
Make slave monsters chase after what their master is chasing, instead of merely following him until he attacks or uses a skill on a target.
That way if the master is immobilized during chasing,
the slaves will still continue to chase and attack once getting in range.
Before this fix Hunters could Ankle Snare Orc Hero for example,
making his slaves completely unresponsive for the trap duration.
Change has been tested and found to be working well
Issues addressed: None?