Skip to content

Conversation

@skyleo
Copy link
Contributor

@skyleo skyleo commented Oct 15, 2019

Pull Request Prelude

Changes Proposed

Make slave monsters chase after what their master is chasing, instead of merely following him until he attacks or uses a skill on a target.

That way if the master is immobilized during chasing,
the slaves will still continue to chase and attack once getting in range.

Before this fix Hunters could Ankle Snare Orc Hero for example,
making his slaves completely unresponsive for the trap duration.

Change has been tested and found to be working well

Issues addressed: None?

@skyleo skyleo added type:bug Issue is a bug or describes an incorrect behavior that should be fixed component:mechanics Affecting the game mechanics in general status:code-review Awaiting code review severity:3-medium Issues with GM commands, script commands, and other commonly used features labels Oct 15, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@skyleo skyleo requested a review from MishimaHaruna October 15, 2019 00:43
@4144
Copy link
Contributor

4144 commented Oct 15, 2019

better squash fixup commit with actual commits with changes. I mean better not create separate commits with compilation fixes

@skyleo
Copy link
Contributor Author

skyleo commented Oct 15, 2019

better squash fixup commit with actual commits with changes. I mean better not create separate commits with compilation fixes

Yes, those will be squashed, but for the review they're there atm, so people aren't confused by me rebasing and changing the history.
There will be only 2 commits at the end of this Pull Request.

@skyleo
Copy link
Contributor Author

skyleo commented Oct 16, 2019

@4144 We're assuming safely at a few places that the master is of type BL_MOB in mob->ai_sub_hard_slavemob in those changes. If you know of cases where this is not the case, please tell me so I can modify the changes.

Also squashed everything reviewed so far, except for Removing trailing whitespace and a new suggestion that has been applied.

@skyleo skyleo force-pushed the slave_anklesnare_fix branch 2 times, most recently from 887c0b9 to f55481e Compare October 16, 2019 11:46
@MishimaHaruna MishimaHaruna added this to the Release v2019.10.20 milestone Oct 16, 2019
This fixes slaves not chasing after master's chase target,
when master was immobilized by an Ankle Snare for example midway.
@skyleo skyleo force-pushed the slave_anklesnare_fix branch from f55481e to c0e2558 Compare October 18, 2019 20:52
@skyleo
Copy link
Contributor Author

skyleo commented Oct 18, 2019

Squashed all that needed to be squashed ~
Ready to be merged.

@MishimaHaruna MishimaHaruna merged commit 6608308 into HerculesWS:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:mechanics Affecting the game mechanics in general severity:3-medium Issues with GM commands, script commands, and other commonly used features status:code-review Awaiting code review type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants