Skip to content

Conversation

@MishimaHaruna
Copy link
Member

Pull Request Prelude

Changes Proposed

  1. Clear the party ID from the saved character data, when leaving or getting kicked (causing database inconsistencies)
  2. Clear the cached guild pointer when the guild ID is cleared, upon error (dangling pointer).
  3. Clear the (clientside) party name from all the party members when a party is disabanded (just visual).

Issues addressed: Point 2 is a possible cause of the crash described in #1266

@MishimaHaruna MishimaHaruna added this to the Release v2019.10.20 milestone Oct 18, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@MishimaHaruna MishimaHaruna merged commit 574e63d into HerculesWS:master Oct 19, 2019
@MishimaHaruna MishimaHaruna deleted the cached-info-fixes branch October 19, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants