Skip to content

Console command fixes #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 2 commits into from
Oct 19, 2019
Merged

Console command fixes #2563

MishimaHaruna merged 2 commits into from
Oct 19, 2019

Conversation

@MishimaHaruna
Copy link
Member

@MishimaHaruna MishimaHaruna commented Oct 18, 2019

Pull Request Prelude

Changes Proposed

  • Fixed the gm:info console command to correctly set the mapindex for the dummy console SD
  • Fixed a crash in the console message parser, when processing a string consisting of only spaces (i.e. press Space, then Return on the console)
  • Fixed console command argument processing: when multiple spaces are passed at the beginning of a command, now they're correctly stripped before calling the command handler

Issues addressed: None

@MishimaHaruna
Fix a missing mapindex update in the gm:info console command
2f27b0a 
Signed-off-by: Haru <[email protected]>
@MishimaHaruna
Fix some issues with the strtok output in the console command parser
f174b0c 
- Fixes a crash in the console command parser when a line consisting
  only of spaces is executed.
- Fixes some extra spaces accidentally passed at the beginning of the
  argument string to console commands, if the input started with
  multiple adjacent spaces.

Signed-off-by: Haru <[email protected]>
@MishimaHaruna MishimaHaruna added this to the Release v2019.10.20 milestone Oct 18, 2019
@HerculesWSAPI
Copy link
Contributor

HerculesWSAPI commented Oct 18, 2019

This change is Reviewable

@MishimaHaruna MishimaHaruna changed the title Cpcmds fixes Console command fixes Oct 18, 2019
@MishimaHaruna MishimaHaruna merged commit ddd0e46 into HerculesWS:master Oct 19, 2019
@MishimaHaruna MishimaHaruna deleted the cpcmds-fixes branch October 19, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4144 4144 4144 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release v2019.10.20

Development

Successfully merging this pull request may close these issues.

3 participants

@MishimaHaruna @HerculesWSAPI @4144