Skip to content

add getguildinfo() #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 7 commits into from
Nov 17, 2019
Merged

add getguildinfo() #2566

MishimaHaruna merged 7 commits into from
Nov 17, 2019

Conversation

@Helianthella
Copy link
Member

@Helianthella Helianthella commented Oct 20, 2019

Pull Request Prelude

Changes Proposed

Adds getguildinfo() and deprecates getguildname(), getguildmaster(), getguildmasterid()

Script conversion:

find npc db -type f -exec sed -i -e "s/getguildname(/getguildinfo(GUILDINFO_NAME, /g" \
-e "s/getguildmaster(/getguildinfo(GUILDINFO_MASTER_NAME, /g" \
-e "s/getguildmasterid(/getguildinfo(GUILDINFO_MASTER_CID, /g" {} +

@Helianthella Helianthella added component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder labels Oct 20, 2019
Helianthella
Helianthella commented Oct 20, 2019
View reviewed changes
@Helianthella Helianthella added this to the Release v2019.11.17 milestone Oct 20, 2019
@Helianthella Helianthella added the component:scripts Affecting the scripts and NPCs label Oct 20, 2019
4144
4144 requested changes Oct 20, 2019
View reviewed changes
src/map/script.c
break;
default:
ShowError("script:getguildinfo: unknown info type!\n");
st->state = END;
Copy link
Contributor

@4144 4144 Oct 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here probably better add always triggered assert for dump call stack

Copy link
Member Author

@Helianthella Helianthella Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returning false already triggers reportsrc

Copy link
Contributor

@4144 4144 Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reportsrc not show call stack. it show only some info about npc

@bWolfie
Copy link
Contributor

bWolfie commented Oct 23, 2019

nice one

@MishimaHaruna MishimaHaruna merged commit d92a4cd into HerculesWS:master Nov 17, 2019
@Helianthella Helianthella deleted the guild branch November 17, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4144 4144 4144 requested changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

component:core:scriptengine Affecting the script engine or the script commands component:documentation Affecting the documentation in the doc/ folder component:scripts Affecting the scripts and NPCs

Projects

None yet

Milestone

Release v2019.11.17

Development

Successfully merging this pull request may close these issues.

4 participants

@Helianthella @bWolfie @4144 @MishimaHaruna