Skip to content

Dehardcode combo skills check #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 1 commit into from
Nov 17, 2019
Merged

Dehardcode combo skills check #2573

MishimaHaruna merged 1 commit into from
Nov 17, 2019

Conversation

@Asheraf
Copy link
Contributor

@Asheraf Asheraf commented Oct 29, 2019

Pull Request Prelude

Changes Proposed

Move skill combo check to a skill db flag instead of hardcoded list

Issues addressed:

@MishimaHaruna MishimaHaruna added this to the Release v2019.11.17 milestone Nov 17, 2019
@MishimaHaruna MishimaHaruna merged commit e09c7e1 into HerculesWS:master Nov 17, 2019
@Asheraf Asheraf deleted the dehardcodecomboskills branch June 2, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4144 4144 4144 approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release v2019.11.17

Development

Successfully merging this pull request may close these issues.

3 participants

@Asheraf @4144 @MishimaHaruna