Fix racial crit bonuses not being affected by katar crit bonus #2588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyleo
added
status:inprogress
Contributor
Author
|
Reviews are welcome now. |
4144
approved these changes
Nov 25, 2019
Emistry
reviewed
Nov 26, 2019
skyleo
changed the title
skyleo
force-pushed
the
racialcritfix
branch
from
dc5137f to
c4d3b74
Compare
skyleo
force-pushed
the
racialcritfix
branch
from
c4d3b74 to
a09352e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Make racial crit bonuses affected by the katar crit bonus.
(Such as Goblin Steamrider Card for example)
Proof/Test
First: We're assuming that this part of katar crit bonus didn't change in Renewal.
Test was done on 11.3 Ep Aegis Server.
Assassin had 42 LUK.
Equipment was Specialty Jur[4] with 4x Goblin Steamrider Cards and 2x Critical Rings.
Crit Shield of Sleeper is 5.6
Crit without Goblin Steamrider Cards is 50 - 5.6 = 44.4
IF katar crit bonus doesn't affect goblin steamrider cards then that would be 72,4 Crit against Sleepers.
Since it does affect them it's 100,4 as the test showed.
Issues addressed: None?