Skip to content

Conversation

@hemagx
Copy link
Contributor

@hemagx hemagx commented Nov 27, 2019

Pull Request Prelude

Changes Proposed

The current behavior of Tarot Card breaking card is to break any equipment except weapon, however after referring to Aegis both for EP12.1 and EP14.3 the code clearly showed it only break Left Arm (Shield), Armor and Helm.
as an extra for future reference chemical protection is not bypassed by this breaking behavior.

The aeigs code snippets is as the following

{
	CPCBattle::ReflectDamage(v2, other, 1000);
	if ( !v5 )
	{
		v7 = GetServerRandom(0, 20000) % 3;
		if ( !v7 )
		{
			CPC::OnDamagedArmor((CPC *)other);
			return 4;
		}
		if ( v7 == 1 )
		{
			CPC::OnDamageEquipment((CPC *)other, 256);
			return 4;
		}
		CPC::OnDamageEquipment((CPC *)other, 32);
	}
	result = 4;
}

All inner functions has been checked for any other behaviors and confirmed as well.

Issues addressed:

…er on Aegis it only target Left Hand (Shield), Armor and Helm

Signed-off-by: Ibrahim Zidan <[email protected]>
@hemagx hemagx added this to the Release v2019.12.15 milestone Nov 27, 2019
@MishimaHaruna MishimaHaruna merged commit 3e35bb9 into master Dec 15, 2019
@MishimaHaruna MishimaHaruna deleted the tarot_card_fix branch December 15, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants