Fix Tarot Card breaking equipment behavior #2589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
The current behavior of Tarot Card breaking card is to break any equipment except weapon, however after referring to Aegis both for EP12.1 and EP14.3 the code clearly showed it only break Left Arm (Shield), Armor and Helm.
as an extra for future reference chemical protection is not bypassed by this breaking behavior.
The aeigs code snippets is as the following
{ CPCBattle::ReflectDamage(v2, other, 1000); if ( !v5 ) { v7 = GetServerRandom(0, 20000) % 3; if ( !v7 ) { CPC::OnDamagedArmor((CPC *)other); return 4; } if ( v7 == 1 ) { CPC::OnDamageEquipment((CPC *)other, 256); return 4; } CPC::OnDamageEquipment((CPC *)other, 32); } result = 4; }All inner functions has been checked for any other behaviors and confirmed as well.
Issues addressed: