Skip to content

Adding PCBLOCK_NPC to setpcblock script command #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 1 commit into from
Jan 12, 2020
Merged

Adding PCBLOCK_NPC to setpcblock script command #2606

MishimaHaruna merged 1 commit into from
Jan 12, 2020

Conversation

@Ridley8819
Copy link

@Ridley8819 Ridley8819 commented Jan 8, 2020 •
edited
Loading

Pull Request Prelude

Changes Proposed

PCBLOCK_NPC for setblock script command to prevent players interacting with NPCs (e.g. During some npctalk dialogue). This is required for some official behaviours.

Issues addressed:

@Ridley8819 Ridley8819 requested a review from 4144 January 8, 2020 00:25
@Ridley8819 Ridley8819 force-pushed the pcblocknpc branch 2 times, most recently from 8b9f552 to 1d22155 Compare January 8, 2020 03:06
Kenpachi2k13
Kenpachi2k13 requested changes Jan 8, 2020
View reviewed changes
@Ridley8819 Ridley8819 force-pushed the pcblocknpc branch 3 times, most recently from 234aac0 to da16756 Compare January 8, 2020 03:29
@Ridley8819 Ridley8819 added codereview:accepted Code review was positive and the pull request can be accepted as is component:core:scriptengine Affecting the script engine or the script commands type:enhancement Issue describes an enhancement or feature that should be implemented labels Jan 8, 2020
Kenpachi2k13
Kenpachi2k13 requested changes Jan 8, 2020
View reviewed changes
@MishimaHaruna MishimaHaruna added this to the Release v2020.01.12 milestone Jan 8, 2020
@MishimaHaruna MishimaHaruna merged commit 7391e5d into HerculesWS:master Jan 12, 2020
@pazkero pazkero mentioned this pull request Feb 14, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4144 4144 4144 approved these changes

@Kenpachi2k13 Kenpachi2k13 Kenpachi2k13 approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

codereview:accepted Code review was positive and the pull request can be accepted as is component:core:scriptengine Affecting the script engine or the script commands type:enhancement Issue describes an enhancement or feature that should be implemented

Projects

None yet

Milestone

Release v2020.01.12

Development

Successfully merging this pull request may close these issues.

4 participants

@Ridley8819 @4144 @Kenpachi2k13 @MishimaHaruna