Skip to content

Fix redefine HPM structs in multy file plugins #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MishimaHaruna merged 1 commit into from
Jan 12, 2020
Merged

Fix redefine HPM structs in multy file plugins #2608

MishimaHaruna merged 1 commit into from
Jan 12, 2020

Conversation

@4144
Copy link
Contributor

@4144 4144 commented Jan 8, 2020

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

With some compilers if build complex plugins, can exists redefine issue for HPM interfaces.
In this pr added special check for avoid this issue.

@MishimaHaruna MishimaHaruna added this to the Release v2020.01.12 milestone Jan 12, 2020
@MishimaHaruna MishimaHaruna merged commit fe7af0a into HerculesWS:master Jan 12, 2020
@4144 4144 deleted the fixhpm branch May 14, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release v2020.01.12

Development

Successfully merging this pull request may close these issues.

2 participants

@4144 @MishimaHaruna