Expand column size of ipbanlist.list from 13 to 39
#2665
Merged
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenpachi2k13
added
type:enhancement
Kenpachi2k13
requested review from
4144,
Asheraf,
MishimaHaruna,
dastgirp,
hemagx and
skyleo
4144
approved these changes
Mar 22, 2020
MishimaHaruna
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
In #2583 the column size of
ipbanlist.listwas changed to 13 to match the server specific format. @pazkero mentioned that custom code may uses a complete IP for bans. Thus the column size should be expanded at least to 15.To enable custom code to even use IPv6 addresses it should be expanded to 39.
Closes #2631