getpartymember upgrade

[jasonch35]

Pull Request Prelude

• [x ] I have followed proper Hercules code styling.
• [x ] I have read and understood the contribution guidelines before making this PR.
• [x ] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Hi, I'd like to share my version of the getpartymember script command, similar to getunits.

This updated version no longer uses global temporary variables, which are prone to being overwritten, especially when multiple players call the function simultaneously. Instead, it requires the scripter to declare an array as an argument in the 3rd parameter of the command.

Additionally, this change introduces the following constants: PT_MEMBER_NAME, PT_MEMBER_CHARID, and PT_MEMBER_ACCID. The function now also returns the size of the party.

Sample usage:

.@count = getpartymember(getcharid(CHAR_ID_PARTY), PT_MEMBER_NAME, .@name$);
for (.@i = 0; .@i < .@count; .@i++) {
	consolemes(CONSOLEMES_DEBUG, ""+.@name$[.@i]+"");
}

The existing script will be deprecated, but I will gladly update all current NPC scripts to use this new version if approved. I can apply similar updates to getguildmember and getmobdrops as well.

I think this approach aligns more closely with Herc's style.

Issues addressed:
Wrong data when multiple players call the command.

[MishimaHaruna]

Hello, and thank you for sharing! Please do update the scripts when you have time to do so (in a separate commit).

I think it looks good. Even if still in draft, I went alread and added some review comments. Please have a look at them.

[MishimaHaruna]

Looks good! Will you update the scripts (luckily there aren't a lot of calls to this command, I only see 16) and the script_commands.txt documentation?