Skip to content

Conversation

@skyleo
Copy link
Contributor

@skyleo skyleo commented Sep 25, 2024

Pull Request Prelude

Changes Proposed

Ensure that on relog the previously removed plagiarized skill doesn't get re-added.

This was due to failure to clear the remembered cloneskill script variables and such.

As by the comment [Aegis] can't overwrite skill of higher level, but will still remove previously copied skill. this is official behavior, that if you had a plagiarized spell, something would attack you with for example Envenom 3, when you have Envenom 10, you'd then lose the plagiarized spell but not have your higher level Envenom overwritten.

That being said I may consider changing it so that if it tries to copy the same level nothing happens. Or re-check if in Aegis this really will result in the removal as well, in case I missed the == case.

Issues addressed: None

@MishimaHaruna MishimaHaruna added this to the Release v2024.09 milestone Sep 28, 2024
@MishimaHaruna MishimaHaruna merged commit 58b217e into HerculesWS:master Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants