Skip to content

Conversation

@ahoyaharr
Copy link
Contributor

@ahoyaharr ahoyaharr commented Oct 21, 2024

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Issues addressed:

  • Adds Inherit field to documentation in mob_db2
  • Fixes a comment about Magnum Break's auto attack modifier

db/mob_db2.conf Outdated
values from mob_db using
Id as the primary key.
Individual items in a nested
field (e.g., Drops) can be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bit about overriding drops documented elsewhere with this wording? Because I don't think it's exactly correct, I believe it's currently a bit complicated to properly override drops without breaking anything

If I'm not missing anything in the existing code, it's currently possible to override each drop slot sequentially, but there's no way to cleanly override a slot while leaving the previous ones untouched

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed now.

@MishimaHaruna MishimaHaruna added this to the Release v2024.11 milestone Oct 31, 2024
@MishimaHaruna MishimaHaruna merged commit c4ad5a3 into HerculesWS:master Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants