Fix error creating folder while installing a wine version #4754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a wine version was removed, the versionInfo.installDir variable was set to '' instead of undefined, so trying to install it again would fail while creating the folder. Fix that by checking if versionInfo is undefined OR ''.
|
Simplified as requested |
flavioislima
requested review from
a team,
arielj,
flavioislima,
CommandMC,
Etaash-mathamsetty,
biliesilva,
Nocccer and
imLinguin
and removed request for
a team
flavioislima
added
the
pr:ready-for-review
arielj
approved these changes
Jul 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a wine version was removed, the versionInfo.installDir variable was set to empty instead of undefined, so trying to install it again would fail while creating the folder. Fix that by checking if versionInfo is undefined OR empty. Now removing and installing the same wine version without closing and opening again heroic works as expected.
Use the following Checklist if you have changed something on the Backend or Frontend: