Conversation
…ttrs, logo/icon inconsistency, error handling Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix critical issues identified in the project
Fix critical bugs: missing remote files, wrong type annotations, duplicate HTML attributes, logo/icon mismatch, unsafe error handling
Feb 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses several build/runtime and rendering issues in the Lumocs/Lume setup by removing stale remote asset references, correcting TypeScript callback typing, fixing template rendering bugs, and narrowing unsafe error handling in the project initializer.
Changes:
- Remove non-existent Nunjucks templates from
mod.tsremote file registration to prevent build-time failures. - Fix
site.processcallback type annotations inplugins.tsto reflect that an array of pages is passed. - Correct template issues in
nav.njk/sidebar.njk(logo source mismatch and duplicatetitleattributes). - Restrict
createFileIfNotExiststo only create files onDeno.errors.NotFound, avoiding writes on other read errors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/_includes/partials/sidebar.njk |
Fixes logo rendering source and removes duplicate title attribute in top links. |
src/_includes/partials/nav.njk |
Removes duplicate title attribute in top links. |
plugins.ts |
Corrects site.process callback parameter typing to Page[]. |
mod.ts |
Removes stale remoteFile registrations for templates that do not exist. |
init.ts |
Narrows catch behavior to only create files on NotFound; cleans up unused catch variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Hexagon <419737+Hexagon@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mod.ts: Remove references to non-existent files (_includes/layout/body.njk,_includes/page_right.njk,_includes/components/toc.njk)plugins.ts: Correct type annotation fromPagetoPage[]in bothsite.processcallbackssrc/_includes/partials/sidebar.njk: Fixmetas.icon→metas.logoinconsistencysrc/_includes/partials/nav.njk: Remove duplicatetitleattribute on top_links anchorsrc/_includes/partials/sidebar.njk: Remove duplicatetitleattribute on top_links anchorinit.ts: Narrow error handling toDeno.errors.NotFound; treat any successful read as "file exists" (return early unconditionally, not only when content is non-empty)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.