Skip to content

Customized and draggable favorites view(#626) #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kristavlastou
Copy link
Contributor

So me and @EvaNtziou implemented the features described in issue #626 for the favorites section.
So now you can:
1.Add or remove an item from favorites
2.Add more than one item to favorites at the same time if multiple items are selected
3.Be able to drag files and folders from the desktop to the favorites view

We did our best but we work on Windows so let us know if any issue occurs when you merge it. We are more than happy to help resolve it to ensure the best result!
Thank you very much
Below is a reference picture of how it looks like :
favorites view

@jelveh
Copy link
Contributor

jelveh commented May 8, 2025

Hi @kristavlastou,
Thank you very much for this PR. I will test and get back to you soon.

@KernelDeimos
Copy link
Contributor

Manually tested, found a blocking issue. I am unable to open a folder window in my local instance of Puter after this change. The following console error is logged.

image

(as an aside, the verbose print of "Sidebar droppable initialized" should also be removed)

For additional information, I checked the line in UIWindow it's complaining about and I see that it's an iterator on window.sidebar_items (second line here):

                let items = JSON.parse(window.sidebar_items);
                for(let item of items){

In the development console, window.sidebar_items evaluates to null.

@kristavlastou
Copy link
Contributor Author

Okay thank you for your feedback ! We checked and changed some parts of the code and it has to be working now. If something occurs let us know!

@jelveh
Copy link
Contributor

jelveh commented Jun 28, 2025

Hi @kristavlastou, I was testing this and I can't really open the explorer any longer. When I click it, I get the following error:

Screenshot 2025-06-28 at 10 14 23 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants