Skip to content

Support the serviceWorkerRegistration option for deleteToken#2

Open
HillBryan wants to merge 7 commits intomainfrom
delete-token-custom-sw
Open

Support the serviceWorkerRegistration option for deleteToken#2
HillBryan wants to merge 7 commits intomainfrom
delete-token-custom-sw

Conversation

@HillBryan
Copy link
Owner

@HillBryan HillBryan commented Nov 17, 2025

Discussion

  • Only getToken accepts a serviceWorkerRegistration option.
  • This MR adds the same option to deleteToken.
  • Without this change, one must first call getToken at some point in the same session before deleteToken. Otherwise, the messaging instance will have no visibility to the custom service worker.

Testing

  • Unit tests are included
  • Manually tested

API Changes

  • This is a backwards compatable API change to deleteToken.
  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@HillBryan HillBryan changed the title Delete token custom sw Support the serviceWorkerRegistration option for deleteToken Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant