Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
trickfu
changed the title
| </div> | ||
| )} | ||
| </div> | ||
| {prevTerms.length > 0 && <div className={styles.prevTerms}>{prevTerms.join(', ')}</div>} |
There was a problem hiding this comment.
Are we using the .svg files?
There was a problem hiding this comment.
no sorry I added these because I previously thought my task was to display the semester tags. I can remove these when I fix this pr. I'll get this fix in when I get clarification on how I should approach DashboardSearchItem firing a separate backend request
There was a problem hiding this comment.
Right now, each DashboardSearchItem is firing a separate backend request. This would be bad for large queries (for example, look at the network requests under the developer console when you query 'c' in the search bar). Not sure what the best way to do this is, but one idea is to do these queries in DashboardSearchResults or Canvas
There was a problem hiding this comment.
I think that if we were to do these in the initial search for the terms, the time it takes for the cards to load would increase. Having a quick loading for the cards then this happening next felt like it made sense, but I also understand the issue with a separate backend request. I can try to do that if we believe that would be better.
There was a problem hiding this comment.
Let's try doing it in the initial search and see if we can make it fast enough. If we can't, then we can discuss what the alternative is.
2 participants
References
Proposed Changes
added an api endpoint in backend > hoagieplan > api > dashboard > details.py because prior I think it would only return the most recent term from guid. I added this so now it records ALL prior terms that are in the DB
in the front end I added the module to fit the italics text and actually display
i have it display previous terms offered including the current one like spring 2026
miscellaneous I thought this was adding the semester tag in previous commits but realized that was another task. I have removed my additions for semester tag :)