Skip to content

Conversation

@khipp
Copy link
Member

@khipp khipp commented Jun 10, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@khipp khipp changed the title fetch: add zap stanza fetch: update livecheck, add zap stanza Jun 10, 2024
@miccal miccal changed the title fetch: update livecheck, add zap stanza fetch: update livecheck, add zap stanza and depends_on Jun 11, 2024
@miccal miccal added the ready to merge PR can be merged once CI is green label Jun 11, 2024
@krehel krehel merged commit bdaca4f into Homebrew:master Jun 11, 2024
@khipp khipp deleted the update-fetch branch June 11, 2024 00:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants