Skip to content

Conversation

@unitof
Copy link
Contributor

@unitof unitof commented Jul 3, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added the missing zap Cask is missing a zap stanza, please add one. label Jul 3, 2024
@unitof
Copy link
Contributor Author

unitof commented Jul 3, 2024

It's 32 bit app. I just noticed missing desc while browsing. Should it be deprecated instead?

@krehel
Copy link
Member

krehel commented Jul 3, 2024

Probably disabled is better, with :unmaintained. Considering 32-bit support was dropped in 2019 and this app has been on version 5.3.1301 since that number was introduced 2015. I think it's safe to say this is not developed any longer.

@bevanjkay bevanjkay added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jul 4, 2024
@krehel krehel force-pushed the fix-flashdecompilertrillix branch from cff53c0 to 4cc3a67 Compare July 5, 2024 00:10
@krehel krehel added the ready to merge PR can be merged once CI is green label Jul 5, 2024
@krehel krehel changed the title flash-decompiler-trillix: add desc flash-decompiler-trillix: disable Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. missing zap Cask is missing a zap stanza, please add one. ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants