Skip to content

5kplayer: 6.10.0, auto_updates and fix livecheck#205297

Merged
bevanjkay merged 1 commit intoHomebrew:masterfrom
eleanordoesntcode:tests
Mar 20, 2025
Merged

5kplayer: 6.10.0, auto_updates and fix livecheck#205297
bevanjkay merged 1 commit intoHomebrew:masterfrom
eleanordoesntcode:tests

Conversation

@eleanordoesntcode
Copy link
Copy Markdown
Contributor

App does have an auto-updater (seen in-app).

@eleanordoesntcode
Copy link
Copy Markdown
Contributor Author

Note: livecheck differs, will fix. Don't merge yet.

@eleanordoesntcode
Copy link
Copy Markdown
Contributor Author

Additional notes: it seems the disk image contains a folder named .HFS+ Private Directory Data?, which brew struggles with. I'll probably have to open an issue in homebrew/brew.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Mar 17, 2025
Comment thread Casks/5/5kplayer.rb Outdated
Comment thread Casks/5/5kplayer.rb Outdated
@eleanordoesntcode eleanordoesntcode changed the title 5kplayer: auto_updates 5kplayer: 6.10.0, auto_updates and fix livecheck Mar 18, 2025
@bevanjkay
Copy link
Copy Markdown
Member

I think we may need to wait for the next Brew release to merge this, because the fix for the installation won't be generally available yet.

@eleanordoesntcode
Copy link
Copy Markdown
Contributor Author

Alright!

@khipp
Copy link
Copy Markdown
Member

khipp commented Mar 20, 2025

I pushed a small update to modify the livecheck block since we only need to check the item for the latest release. I also moved the comment above the livecheck, as that is our usual pattern.

@bevanjkay bevanjkay merged commit 2034241 into Homebrew:master Mar 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

livecheck Issues or PRs related to livecheck

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants