Skip to content

go 1.9.1 #19000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

go 1.9.1 #19000

wants to merge 2 commits into from

Conversation

leonklingele
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@leonklingele
Copy link
Contributor Author

This release fixes two security issues, golang/go#22131 and golang/go#22133

@cblecker
Copy link
Contributor

cblecker commented Oct 4, 2017

@leonklingele You need to bump the revision on Formulas/godep.rb

@leonklingele
Copy link
Contributor Author

@cblecker done. I wonder why this needs to be done though.

@fxcoudert
Copy link
Member

Thanks @leonklingele for the pull request!

@fxcoudert fxcoudert closed this in 3bf51e5 Oct 4, 2017
@DomT4
Copy link
Contributor

DomT4 commented Oct 4, 2017

I wonder why this needs to be done though.

The godep executable stores the full Cellar path to go rather than the opt_prefix, sadly.

@cblecker cblecker mentioned this pull request Jan 22, 2018
4 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants