Fix OpenBLAS pkg-config OpenMP flag on macOS #230188
Conversation
The OpenBLAS pkg-config file includes `-fopenmp` which is not supported by macOS's default clang compiler, causing build failures for dependent packages. This patch removes the unsupported flag on macOS while preserving OpenMP support on other platforms. Fixes issues with packages that depend on OpenBLAS and use pkg-config for configuration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
github-actions
bot
added
autosquash
|
This patch fixes ocaml/opam-repository#27483 |
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
Related PR: #219339 |
| pkgconfig_file = lib/"pkgconfig/openblas.pc" | ||
| pkgconfig_content = pkgconfig_file.read | ||
| pkgconfig_file.write pkgconfig_content.gsub(/^omp_opt=-fopenmp$/, "omp_opt=") |
There was a problem hiding this comment.
You should use inreplace here.
| @@ -61,6 +61,13 @@ def install | |||
|
|
|||
| lib.install_symlink shared_library("libopenblas") => shared_library("libblas") | |||
| lib.install_symlink shared_library("libopenblas") => shared_library("liblapack") | |||
|
|
|||
| # Fix pkg-config file on macOS to remove unsupported -fopenmp flag | |||
| if OS.mac? | |||
There was a problem hiding this comment.
Do an early return (i.e. return unless OS.mac?) so you don't have to indent everything below here.
|
Yeah the Clang equivalent is I suspect the flag is only necessary for static linking, where you would need libgomp.a. In theory that means it should go in We presumably didn't notice the issue ourselves because our compiler shims will filter out |
|
Right now we compile openblas against GCC (due to Fortran and OpenMP use). So that means our pkgconfig file ships GCC options. It works fine with all our packages. The problem arises from ocaml/opam wanting to combine our openblas with clang. They should use another openblas build, or switch to GCC. We aim to support consistent use cases, but can't support every compilation setup. Moreover, removing the So I'm 👎 on the PR. |
Yeah, it has been discussed on #209091 that the way forward would be to have another formula, which uses a build of openblas with clang (I am not sure whether this should be Apple's clang from xcode, or the one from and libomp (not libgomp). (One must not mix libomp and libgomp, and libgomp is not supported by clang). gfortran works fine with libomp, and openbpas now has a cmake build option which allows this configuration to be used in build. (see OpenMathLib/OpenBLAS#5169 and OpenMathLib/OpenBLAS#5180) It would be great to have such a formula available, either here (in homebrew core), or in a separate tap. |
The OpenBLAS pkg-config file includes
-fopenmpwhich is not supported by macOS's default clang compiler, causing build failures for dependent packages. This patch removes the unsupported flag on macOS while preserving OpenMP support on other platforms.Fixes issues with packages that depend on OpenBLAS and use pkg-config for configuration.
🤖 Generated with Claude Code