kubernetes-cli 1.9.4

[cblecker]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

Change the build dependency for kubernetes-cli to use [email protected]. We don't support go1.10 yet for kubectl.

fixes #25312.

[ilovezfs]

I'm not eager to allow the use of go@* formulae as dependencies in Homebrew/homebrew-core as that has not be needed at all so far. What is the blocker to using the latest Go?

[cblecker]

The homebrew compile failure is here: #25312
There was a crypto/tls regression (golang/go#23884) that has prevented our upgrade (kubernetes/kubernetes#60597). We can't update our master branch to go1.10 until go1.10.1 comes out, which means due to our release cycle that it won't hit a stable release until kubernetes 1.11 (estimated release in June 2018).

[ilovezfs]

Can we cherry-pick the fix into Homebrew's Go 1.10?

[cblecker]

I don't think that alone will work, as the homebrew compile failure is on a go dependency in the release branch that would need to be bumped along side the upgrade.

[ilovezfs]

That is a shame.

[cblecker]

Yeah.. I just tugged on the thread, and the dependency that is failing to compile is actually a dependency of dependency (cfssl). So it's unfortunately a chain reaction that's preventing it.

From an upstream perspective, we pin our go versions in our build container system that we use to generate the release binaries for this reason. We've also seen large performance regressions in the past as well. So using go1.9 is the most "right" from our side. I can understand that not being the preference from the homebrew side, however.

[ilovezfs]

there is no patch for cfssl?

[cblecker]

There is, but it hasn't been regression tested in the 1.9 release branch, or on master. We're in the kubernetes 1.10 freeze window right now (to be released in the next two weeks), so we can't upgrade it on master, let alone on a release branch.

The upstream fix path as I'd see it:

• Our master opens for work on kubernetes 1.11 (within next two weeks)
• Wait for go1.10.1 to be released to fix the crypto/tls regression
• Upgrade and run our build system with it
• Upgrade dependencies (cfssl)
• Regression, scale, and performance testing against go1.10
• Stable release of kubernetes 1.11 in ~June 2018

[ilovezfs]

I don't like this precedent we're setting right now at all, but OK.

[ilovezfs]

Thanks @cblecker! 🚀

[cblecker]

I completely understand, and appreciate the exception in spite of it. Hopefully this is an extremely short lived state. Not being able to be compiled on the latest go version causes all sorts of bad issues.