Skip to content

arduino-cli 0.5.0 (new formula) #44575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

arduino-cli 0.5.0 (new formula) #44575

wants to merge 7 commits into from

Conversation

Efrat19
Copy link
Contributor

@Efrat19 Efrat19 commented Sep 25, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

this PR is created to meet a feature request at arduino-cli -
arduino/arduino-cli#275

@Efrat19 Efrat19 changed the title Create arduino-cli.rb 0.5.0 arduino-cli 0.5.0 (new formula) Sep 25, 2019
end

test do
system "#{bin}/arduino-cli"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.

In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.

  • Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
  • You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?

Some advice for specific cases:

  • If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
  • If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
  • If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
  • Same if the software requires a virtual machine, docker instance, etc. to be running.

class ArduinoCli < Formula
desc "Arduino command-line interface"
homepage "https://github.com/arduino/arduino-cli"
url "https://github.com/arduino/arduino-cli/releases/download/0.5.0-showports/arduino-cli_0.5.0-showports_macOS_64bit.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be specific to an OS (macOS). For homebrew this downloads needs to be the full source.

@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 26, 2019
@SMillerDev SMillerDev added the needs response Needs a response from the issue/PR author label Sep 30, 2019
@Efrat19
Copy link
Contributor Author

Efrat19 commented Oct 1, 2019

Im working on it please dont close this pr 😆

@Efrat19
Copy link
Contributor Author

Efrat19 commented Oct 6, 2019

Hey @SMillerDev @fxcoudert i was fixing it according to your feedback
it still fails now
the error is with brew audit, which says:

arduino-cli:
  * C: 7: col 6: Don't use OS.mac?; Homebrew/core only supports macOS
  * C: 10: col 9: Don't use OS.linux?; Homebrew/core only supports macOS
Error: 2 problems in 1 formula detected

thats exactly the opposite of what you said above:

This seems to be specific to an OS (macOS). For homebrew this downloads needs to be the full source.

any help?
thanks!
Efrat

@Efrat19 Efrat19 closed this Oct 6, 2019
@Efrat19 Efrat19 reopened this Oct 6, 2019
@Efrat19 Efrat19 closed this Oct 6, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 7, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs response Needs a response from the issue/PR author new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants