Skip to content

pulumi 2.21.2 #71738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pulumi-bot
Copy link
Contributor

action-homebrew-bump-formula


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Feb 22, 2021
@chenrui333 chenrui333 added 11-arm64 Big Sur arm64 is specifically affected build failure CI fails while building the software labels Feb 22, 2021
@chenrui333
Copy link
Member

==> go mod download
Error: Status neither has `exitstatus` nor `termsig`.

@stack72
Copy link
Contributor

stack72 commented Feb 22, 2021

==> go mod download
Error: Status neither has `exitstatus` nor `termsig`.

Hi @chenrui333

So Pulumi hasn't changed here in this regard - I can see the failure in on macOS 11 ARM - we don't publish any ARM packages at this point - is that the issue?

Paul

@stack72
Copy link
Contributor

stack72 commented Feb 22, 2021

I see a similar issue here. Homebrew/brew#10661

@BrewTestBot BrewTestBot added the no ARM bottle Formula has no ARM bottle label Feb 23, 2021
@pulumi-bot
Copy link
Contributor Author

ok, we've just updated this as Pulumi has no arm builds as of this time - this is something we are actively working on

@pulumi-bot
Copy link
Contributor Author

I've just squashed the PR into the single commit

@stack72
Copy link
Contributor

stack72 commented Feb 23, 2021

@chenrui333 sending this your way again now :)

@SMillerDev
Copy link
Member

We have a succesful bottle for ARM so removing it will leave all users with a broken install. This is a regression in pulumi as far as I can see.

@stack72
Copy link
Contributor

stack72 commented Feb 23, 2021

Hi @SMillerDev

I'm not sure how this is a Pulumi regression - Pulumi doesn't support go 1.16 at this point

There are other formulae that don't have this bottle - Terraform for example

I asked above for help in understanding the error but didn't hear back - more than happy to fix this as is needed of course

Paul

@SMillerDev
Copy link
Member

SMillerDev commented Feb 23, 2021

If a bottle exists, that means we were able to compile and test the software on ARM. If we can't build or test on ARM anymore that is a regression.

If terraform does not have a bottle that means we were never able to build/test in the first place.


As for the error, I'm afraid that will be mostly up to you as pulumi developer.

@stack72
Copy link
Contributor

stack72 commented Feb 23, 2021

Ok I'm happy to put that back - I still need a little help in understanding why we were getting the build failure it was the same issue as I linked above

The issue only exists in Mac-11 arm and I don't use that machine type

@Bo98
Copy link
Member

Bo98 commented Feb 23, 2021

I'll try get the vagueness of the error fixed - it's a brew bug that's making it display Status neither has 'exitstatus' nor 'termsig' rather than anything useful.

@chenrui333 chenrui333 removed 11-arm64 Big Sur arm64 is specifically affected build failure CI fails while building the software labels Feb 24, 2021
@Bo98 Bo98 mentioned this pull request Feb 24, 2021
@Josh-Tilles
Copy link
Contributor

Josh-Tilles commented Feb 24, 2021

As a data point: I'm on an M1 running 11.2.1 and I just successfully built Pulumi 2.21.2 from source with the bottled Go 1.16 and brew test pulumi passed.

Is it possible the earlier error was a result of the sporadic SIGILLs observed by M1 users? (If anyone’s unfamiliar with that phenomenon, golang/go#42774 could be worth a look, although I'd appreciate any pointers to any more-authoritative documentation.) Because if the error was transient, there might not actually be any regression in 2.21.2.

@Bo98
Copy link
Member

Bo98 commented Feb 24, 2021

Could maybe try rebase on master, in case it's something fixed between Go 1.16 RC1 (which we used on ARM since there was no stable version) and final.

@BrewTestBot BrewTestBot removed the no ARM bottle Formula has no ARM bottle label Feb 24, 2021
@stack72
Copy link
Contributor

stack72 commented Feb 24, 2021

ok @Bo98 I have rebased and repushed

@stack72
Copy link
Contributor

stack72 commented Feb 24, 2021

Looks better now

@Bo98 Bo98 removed the do not merge label Feb 24, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants