update cmake file for python 3.12 on ubuntu 22 with system python being 3.10 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantuMope
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Hey Le,
On Ubuntu 24.04, I am now getting this error
In file included from /home/asjchoi/Desktop/Code/kincpp/src/kincpp/utils.h:3,
from /home/asjchoi/Desktop/Code/kincpp/src/utils.cpp:1:
/home/asjchoi/Desktop/Code/kincpp/src/kincpp/global_definitions.h:3:10: fatal error: Eigen/Dense: No such file or directory
3 | #include <Eigen/Dense>
| ^~~~~~~~~~~~~
In file included from /home/asjchoi/Desktop/Code/kincpp/src/kincpp/kinematics_solver.h:3,
from /home/asjchoi/Desktop/Code/kincpp/src/kinematics_solver.cpp:1:
/home/asjchoi/Desktop/Code/kincpp/src/kincpp/global_definitions.h:3:10: fatal error: Eigen/Dense: No such file or directory
3 | #include <Eigen/Dense>
| ^~~~~~~~~~~~~
compilation terminated.
compilation terminated.
make[2]: *** [CMakeFiles/kincpp.dir/build.make:90: CMakeFiles/kincpp.dir/src/utils.cpp.o] Error 1
Can confirm that build works on main.
CMakeLists.txt
Outdated
| find_package(Python3 REQUIRED COMPONENTS Interpreter Development) | ||
| find_package(pybind11 REQUIRED) | ||
| find_package(pybind11 CONFIG REQUIRED) | ||
| find_package(Python3 3.12 REQUIRED COMPONENTS Interpreter Development) |
There was a problem hiding this comment.
Instead of hardcoding python 3.12 here, should we add a cmake arg so user can choose?
Ah, not as easy as I thought.. Could you give me access to your env so I can test? Re: hardcoding 3.12, I'm thinking probably choose based on virtualenv. But let me debug this 312 version first. |
I run Ubuntu 24.04 on my home computer. Work computer is 22.04 unfortunately. Yeah choosing based off of virtualenv is definitely the best way! |
…ng 3.10: use the pybind and python version fed in from the input CMAKE_PREFIX_PATH
le-horizon
force-pushed
the
PR/update_cmakefile_for_python312
branch
from
1544b48 to
f1a4363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested, this works on ubuntu 22 with python 3.12.
Andrew, could you test on your ubuntu 24?
Requires Hobot side change to build_rapid_env.py https://github.com/HorizonRoboticsInternal/Hobot/pull/1665
I'll try to test it on ubuntu 22 with python3.10 as well.