Add CallMacro default argument testcase #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balint-R
force-pushed
the
macro-default-arg
branch
3 times, most recently
from
0e75502 to
fe27f7f
Compare
Balint-R
force-pushed
the
macro-default-arg
branch
from
fe27f7f to
8c930e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into how
CallMacros take arguments while working on inline functions. I was slightly confused by their logic for applying default arguments, so I wrote a testcase to make sure it actually works (it does).Also added
visit_Expressiontocompiler.py.ast.Expressionobjects are only generated by functions likeast.parse(code, mode="eval"), but supporting compiling that never hurts.