Update configure

[vjcitn]

reduce conditioning on USE_VBZ, helps with mac arm, will it work elsewhere? seems to work on linux. checking the action on my fork

[grimbough]

Thanks Vince. I've actually added some print statements to the configure script to try and understand why the USE_VBZ isn't being set. However the combination of having to wait a long time to get any feedback from the Mac ARM builder and that I'd need to make these diagnostic changes to the release branch means I've not actually committed them yet.

Perhaps the simplest, short-term, solution to at least get it building on Mac is to turn of the test for the VBZ filter in the case that the filter is missing. I have a function rhdf5filters::available_filters() which should detect which filters have been successfully compiled and let me selectively test only those.

Obviously it'd be nice to get this working properly, but I don't think the VBZ filter is particularly widely used. It's bespoke to Oxford Nanopore, and I don't get the impression many users will miss it.

[vjcitn]

OK Mike. The impression of Herve was that without access to a mac you'd be hardpressed to solve this. I think it would be fine to drop vbz for now. I have been trying to figure out how to offer access to an ARM mac on AWS and that may not be too far off, but our AWS team is maxed out just now. Let me know if that would be important to move on.

…

On Tue, Dec 12, 2023 at 6:03 AM Mike Smith ***@***.***> wrote: Thanks Vince. I've actually added some print statements to the configure script to try and understand why the USE_VBZ isn't being set. However the combination of having to wait a long time to get any feedback from the Mac ARM builder and that I'd need to make these diagnostic changes to the release branch means I've not actually committed them yet. Perhaps the simplest, short-term, solution to at least get it building on Mac is to turn of the test for the VBZ filter in the case that the filter is missing. I have a function rhdf5filters::available_filters() which should detect which filters have been successfully compiled and let me selectively test only those. Obviously it'd be nice to get this working properly, but I don't think the VBZ filter is particularly widely used. It's bespoke to Oxford Nanopore, and I don't get the impression many users will miss it. — Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDI5QTJWKBQBBVYGYYZTX3YJA2ZDAVCNFSM6AAAAABAQS3A3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRHAYTONJZHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance  HelpLine at http://www.partners.org/complianceline <http://www.partners.org/complianceline> . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.

[grimbough]

Yes, I saw your messages in Slack. Thanks very much for looking in to possible solutions. It's indeed tricky to understand the fine details of this compilation issues without access to a Mac.

I think this solution is appropriate here since some systems can't actually run the VBZ code - CPUs older than about 2006 don't have the right instruction set - so it's valid not to provide it under those circumstances. That's what the USE_VBZ conditioning was trying to catch. However that's clearly not the case for modern Mac chips, so I need to figure out why my configure script is rejecting them.