Deal with asynchrony when loading images in CLI #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll want to dig into this one a bit yet. It's also giving me trouble. |
|
This fails silently for me. I'm on OS X 10.9.3 with Attaching the |
|
I derped on this. I was looking at #17 which used |
|
Alright I've merged this! I added b4bddd7 for a little extra error handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change hopefully fixes #17 by waiting for the images to be loaded before doing the diff.
There's some error cases the script doesn't catch, and a rather awkward CLI syntax (
diffnot--diff), but that's for another change to deal with.