-
Notifications
You must be signed in to change notification settings - Fork 0
feat(web): add first-class RTL setup #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e858532
feat(web): add first-class RTL setup
HusseinBaraja cbdfd61
fix(web): restore RTL sidebar item order
HusseinBaraja 76fab8e
fix(web): keep RTL sidebar rail outside
HusseinBaraja 8cffbba
fix(web): restore sidebar rail left border
HusseinBaraja 1b3dc9d
fix(web): scope RTL provider to dashboard
HusseinBaraja d66ca42
fix(web): wrap dashboard sidebar labels
HusseinBaraja df250e4
test(web): assert dashboard RTL props
HusseinBaraja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import * as React from "react" | ||
| import { Direction } from "radix-ui" | ||
|
|
||
| function DirectionProvider({ | ||
| dir, | ||
| direction, | ||
| children, | ||
| }: React.ComponentProps<typeof Direction.DirectionProvider> & { | ||
| direction?: React.ComponentProps<typeof Direction.DirectionProvider>["dir"] | ||
| }) { | ||
| return ( | ||
| <Direction.DirectionProvider dir={direction ?? dir}> | ||
| {children} | ||
| </Direction.DirectionProvider> | ||
| ) | ||
| } | ||
|
|
||
| const useDirection = Direction.useDirection | ||
|
|
||
| export { DirectionProvider, useDirection } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.