Skip to content

Conversation

@rubiin
Copy link
Collaborator

@rubiin rubiin commented Aug 12, 2025

Pull Request

Description

as discussed on the discussion #1119

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • Make sure to make PR against dev and not the master
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

zerokaze420 and others added 17 commits August 5, 2025 17:12
…#1076)

# Pull Request

## Description

Please read these instructions and remove unnecessary text.

- Try to include a summary of the changes and which issue is fixed.
- Also include relevant motivation and context (if applicable).
- Make sure to make PR against dev and not the master
- List any dependencies that are required for this change. (e.g.,
packages or other PRs)
- Provide a link if there is an issue related to this pull request.
e.g., Fixes # (issue)
- Please add Reviewers, Assignees, Labels, Projects, and Milestones to
the PR. (if applicable)

## Type of change

Please put an `x` in the boxes that apply:

- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that would cause existing
functionality to not work as expected)
- [x] **Documentation update** (non-breaking change; modified files are
limited to the documentations)
- [ ] **Technical debt** (a code change that does not fix a bug or add a
feature but makes something clearer for devs)
- [ ] **Other** (provide details below)

## Checklist

Please put an `x` in the boxes that apply:

- [x] I have read the
[CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md)
document.
- [x] My code follows the code style of this project.
- [x] My commit message follows the [commit
guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added a changelog entry.
- [ ] I have added necessary comments/documentation to my code.
- [ ] I have added tests to cover my changes.
- [x] I have tested my code locally and it works as expected.
- [x] All new and existing tests passed.

## Screenshots

(if appropriate)

## Additional context

Add any other context about the problem here.
@github-actions
Copy link
Contributor

⚠️ Warning: PR targeting master branch detected!

This PR is targeting master but should target dev instead.

According to our Quarterly Release Policy:

  • All pull requests must be submitted to the dev branch
  • Changes go through dev first for testing before being merged to master during quarterly release windows (1st & 3rd Fridays)
  • PRs to master are only allowed for emergencies

Required Action:

  1. Change the base branch from master to dev
  2. Follow the pull request template

If this is an emergency fix, please add a comment explaining why it needs to target master directly.


This is an automated message enforcing our quarterly release workflow.

@rubiin rubiin changed the base branch from master to dev August 12, 2025 10:48
@kRHYME7
Copy link
Contributor

kRHYME7 commented Aug 12, 2025

How will the migration scripts trigger and not trigger? will it always trigger?

@kRHYME7
Copy link
Contributor

kRHYME7 commented Aug 12, 2025

This won't solve issues when users do not update for a while. But this should solve issues for anyone religiously following the update so this is Good for now.

@kRHYME7
Copy link
Contributor

kRHYME7 commented Aug 12, 2025

Can you point this pr to master please.

@rubiin
Copy link
Collaborator Author

rubiin commented Aug 12, 2025

How will the migration scripts trigger and not trigger? will it always trigger?

this will always trigger on the updates. will find the latest migration based on the name (sorted by date on descending ) and run it

@rubiin rubiin changed the base branch from dev to master August 12, 2025 11:24
@amit-0i
Copy link
Member

amit-0i commented Aug 12, 2025

what if we name migration scripts to HyDE's cal-ver? we can compare the current and new hyde versions with hyde-shell --version

@rubiin
Copy link
Collaborator Author

rubiin commented Aug 12, 2025

See
image

@rubiin
Copy link
Collaborator Author

rubiin commented Aug 12, 2025

what if we name migration scripts to HyDE's cal-ver? we can compare the current and new hyde versions with hyde-shell --version

can do as long as its sortable.

@rubiin rubiin requested a review from Copilot August 12, 2025 12:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a migration system for HyDE to handle automated updates and configuration changes during restoration. The migration system will execute the latest migration script found in a new migrations directory when the restore flag is enabled.

  • Adds migration system infrastructure with automatic execution during restoration
  • Updates Chinese keybinding documentation with improved translations and path corrections
  • Adds JSON schema reference to the main configuration file

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
migrations/20250815.sh Creates example migration script that reloads Hyde shell shaders
Source/assets/keybinds/KEYBINDINGS.zh.md Updates Chinese documentation with better translations and corrected file paths
Scripts/install.sh Integrates migration system into installation script for restore operations
Configs/.config/hyde/config.toml Adds JSON schema reference for configuration validation

@github-actions
Copy link
Contributor

⚠️ Warning: PR targeting master branch detected!

This PR is targeting master but should target dev instead.

According to our Quarterly Release Policy:

  • All pull requests must be submitted to the dev branch
  • Changes go through dev first for testing before being merged to master during quarterly release windows (1st & 3rd Fridays)
  • PRs to master are only allowed for emergencies

Required Action:

  1. Change the base branch from master to dev
  2. Follow the pull request template

If this is an emergency fix, please add a comment explaining why it needs to target master directly.


This is an automated message enforcing our quarterly release workflow.

@github-actions
Copy link
Contributor

⚠️ Warning: PR targeting master branch detected!

This PR is targeting master but should target dev instead.

According to our Quarterly Release Policy:

  • All pull requests must be submitted to the dev branch
  • Changes go through dev first for testing before being merged to master during quarterly release windows (1st & 3rd Fridays)
  • PRs to master are only allowed for emergencies

Required Action:

  1. Change the base branch from master to dev
  2. Follow the pull request template

If this is an emergency fix, please add a comment explaining why it needs to target master directly.


This is an automated message enforcing our quarterly release workflow.

@rubiin
Copy link
Collaborator Author

rubiin commented Aug 12, 2025

LGTM

@github-actions
Copy link
Contributor

⚠️ Warning: PR targeting master branch detected!

This PR is targeting master but should target dev instead.

According to our Quarterly Release Policy:

  • All pull requests must be submitted to the dev branch
  • Changes go through dev first for testing before being merged to master during quarterly release windows (1st & 3rd Fridays)
  • PRs to master are only allowed for emergencies

Required Action:

  1. Change the base branch from master to dev
  2. Follow the pull request template

If this is an emergency fix, please add a comment explaining why it needs to target master directly.


This is an automated message enforcing our quarterly release workflow.

@kRHYME7 kRHYME7 merged commit 218e8fe into master Aug 12, 2025
4 checks passed
@kRHYME7 kRHYME7 deleted the migrations branch August 12, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants