Skip to content

Conversation

@0xAquora
Copy link
Contributor

Pull Request

Description

Motivation:
Sometimes i want to record a quick video explaining how to do something and opening OBS is too much hassle for such a small task so i decided to implement a few keybindings to make recording videos more comfortable for the users.

Description:
Its a little script that checks the encondings allowed by your gpu and uses slurp to choose the region you want to share, afterwards it gets saved in /Videos.

Dependencies:
wf-recorder

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

0xAquora added 11 commits April 12, 2025 10:59
Added partial screen recording with wf-recorder, recording with audio and stop recording.
added wf-recorder
Was deleted to upload a better configuration.
usage: ./smart-recorder or ./smart recorder --audio to be able to record microphone, autodetects codec depending on your gpu.
The video gets stored in /Videos
The output of the files will appear in the videos folder.
Changed from smart_recording compiled file to sh files.
fixed name of keycap bindings.
deduplicated keybinds
Fixing overlapping keybind v2.

Im blind...
It is unnecesary since its been reworked in sh files.
@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 13, 2025

I don't know, maybe learn how we structure our scripts first?

If it's specific to the wfrecorder, then maybe just put it into a single wfrecorder.sh script?

Fun fact Hyde-CLI had a script for this would you like me to port this to HyDE? It supports 2 backends wfrecorder and wlscreenrec.

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 13, 2025

Would you like me to add it for you?

@0xAquora
Copy link
Contributor Author

Would you like me to add it for you?

Yes please, that would be great!

Also it is true that it all could have fit into a single file commit, i am sorry.

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 13, 2025

Also it is true that it all could have fit into a single file commit, i am sorry.

Yup

This script merges the functionality of get_encoder, record_video and record_video_audio.
Deleted because its been replaced by wf-recorder.sh
Deleted because its been replaced by wf-recorder.sh
Deleted because its been replaced by wf-recorder.sh
Fixed line 131 & 132 to point to the new script wf-recorder.sh.
@0xAquora
Copy link
Contributor Author

I merged the functionality of those 3 files into wf-recorder.sh as adviced and updated keybindings accordingly

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 13, 2025

Do you have any reasons not using wl-screenrec?

@0xAquora
Copy link
Contributor Author

0xAquora commented Apr 13, 2025

Because i am unsure if it works properly with Nvidia GPUs following this image, so since theres different tools for GPUs depending on which specific GPU you've got, i preferred to go with what i saw to be more standardized.

Though if you have any suggestion, i can try to make a script which chooses preferred tool for recording, but i think that should be declared on the installation script to not bloat the user.
image

@TowhidMolla-Dev
Copy link

update?

deleted video recording keybinds
deleleted wf-recorder
added misc wf-recorder
@0xAquora
Copy link
Contributor Author

Changes done, mister 🫡

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 21, 2025

It fails. Do we really need to explicitly add the encoders? I this wf-recorder handles it automatically

image

launching it works

image

@kRHYME7 kRHYME7 changed the title Feature: Adding wf-recorder for quick record. feat: Screen Recorder script Apr 21, 2025
@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 21, 2025

USAGE

screenrecord.sh
BTW hyde-shell calls the scripts in hyde lib which is convenient when scripting or doing some other interopt.

image

Basics for binds

To start

hyde-shell screenrecord --start 

To exit/quit

hyde-shell screenrecord --quit

To use either wl-screenrec or wf-recorder, we can add --backend <backend>

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 21, 2025

@TowhidMolla-Dev @0xAquora Please add your review. this should work for both wl-screenrec and wf-recorder.

Copy link
Contributor Author

@0xAquora 0xAquora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, though i removed the check for hyde-shell on my side because im still with the old dots.

@kRHYME7 kRHYME7 merged commit 9c34033 into HyDE-Project:master Apr 22, 2025
@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 22, 2025

Merging this now, thank you @0xAquora

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants