Skip to content

Add missing modules to Starship config #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kRHYME7 merged 3 commits into from
May 7, 2025
Merged

Add missing modules to Starship config #577

kRHYME7 merged 3 commits into from
May 7, 2025

Conversation

@prime-run
Copy link
Collaborator

@prime-run prime-run commented May 5, 2025

Description

This PR adds missing supported modules to starship.toml config and follows same formatting and styling. Also all icons are switched to HyDE supported nerd Icons

Also all $version are removed from modules! since they are not convenient

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

@prime-run
Copy link
Collaborator Author

prime-run commented May 5, 2025

@kRHYME7 can you please fix your toml formatter 😄😄

@kRHYME7
Copy link
Contributor

kRHYME7 commented May 5, 2025

I'm using prettier and I want it indented. Should we add a formatter ci for this repo?.

I just want a default config for a formatter. I installed the extension then it should work.

@kRHYME7
Copy link
Contributor

kRHYME7 commented May 5, 2025

also don't remove the python version! It's too confusing without a reference to look at too. I do crazy projects and some internal libs need to be on a specific version. So I always keep specific versions of them.

@prime-run
Copy link
Collaborator Author

prime-run commented May 5, 2025 •
edited
Loading

I'm using prettier and I want it indented.

you just "not a bug , a feature"ed me 😄😄

Should we add a formatter ci for this repo?

I haven't really messed with them! are they conflic safe ?!!!

I use harper (written in rust) in nvim as lsp and fallback formatter to lsp for toml.

also don't remove the python version

fixed! i take it as +1 for starship was it easy to pull of in p10k ? 😄 I mean not adding like 30 more lines to .zsh stuff 😄😄

@prime-run prime-run marked this pull request as ready for review May 5, 2025 16:23
@prime-run prime-run requested a review from kRHYME7 May 5, 2025 16:26
@prime-run
Copy link
Collaborator Author

prime-run commented May 6, 2025 •
edited
Loading

Yo @kRHYME7 you got salt on this one bro 😁?

Working on my next starship PR, Tbh i can close and ditch this PR (close it) 😄

@kRHYME7
Copy link
Contributor

kRHYME7 commented May 7, 2025

I forgot

@kRHYME7 kRHYME7 merged commit 12d113b into HyDE-Project:dev May 7, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request May 7, 2025
Merged
@prime-run prime-run deleted the starship-rework branch May 7, 2025 01:50
kRHYME7 added a commit that referenced this pull request May 9, 2025
@kRHYME7
chore: release automated changes from dev to master (#559)
266aa3f 
This is an automated PR to promote changes from `dev` to `master`.
Please review and test before merging.

## For Testers
See [TESTING.md](./TESTING.md) for complete testing instructions.

## Suggested Merge Schedule
According to our release policy, this PR is expected to be merged on:
**Friday**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.
## Commits to be merged:
---
* chore Add keybind for game launcher (#597) (891b181) by ProfShiba
* feat (hyde-ipc): Our very own IPC handler! (5c4221f) by kRHYME7
* fix(zsh): Use `.user.zsh` (f1446ab) by kRHYME7
* feat(hyde-config): A Go implementation of the parse.config.py
(b6c7bb8) by kRHYME7
* chore Add missing modules to Starship config (#577) (12d113b) by
prime-run
* fix: [Bug]: Defer oh-my-zsh loading may not be the best option #578
(882fef0) by kRHYME7
* chore implement fzf-shell integration for `fish` (#575) (e750c97) by
prime-run
* fix(fastfetch): Correct random handler (3cb0434) by kRHYME7
* chore add best fzf aliases ever (#569) (503711a) by prime-run
* fix(zsh): Explicit history integration (55721cb) by kRHYME7
* fixed the link color being same as normal text (#570) (ca3c158) by
amit
* fix: [Bug]: Game Launcher isn't showing anything #447 (96be51a) by
kRHYME7
* chore style: discord dcol file changes (#566) (63a2949) by amit
* chore refactor(zsh): cleanup zsh for incoing fzf features (abc1a7b)
by prime-run
* chore breaking(zsh): move ~/.hyde.zshrc to more consistent name
`~/.user.zsh` (bb76750) by kRHYME7
* chore Merge branch 'master' of https://github.com/hyde-project/hyde
into dev (1254f3f) by kRHYME7
* chore Merge branch 'master' into dev (73efd7c) by Khing
---

Please review the changes carefully before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kRHYME7 kRHYME7 Awaiting requested review from kRHYME7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prime-run @kRHYME7