Skip to content

Conversation

@deepu105
Copy link
Contributor

@deepu105 deepu105 commented Jun 27, 2025

Pull Request

Description

  • Fix a typo
  • Follow symlinks so that script works when using stow for dotfiles

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

Copy link
Contributor

@kRHYME7 kRHYME7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kRHYME7
Copy link
Contributor

kRHYME7 commented Jun 27, 2025

aplease push this to dev branch

@deepu105
Copy link
Contributor Author

deepu105 commented Jun 27, 2025

should all PRs target dev branch?

My bad its mentioned in contributing.md

@deepu105 deepu105 changed the base branch from master to dev June 27, 2025 14:51
@deepu105
Copy link
Contributor Author

rebased

Copy link
Contributor

@kRHYME7 kRHYME7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@kRHYME7 kRHYME7 merged commit 48a7e2a into HyDE-Project:dev Jun 28, 2025
3 checks passed
@deepu105 deepu105 deleted the workflow-fix branch June 28, 2025 11:52
rubiin pushed a commit that referenced this pull request Jul 10, 2025
* fix: follow symlinks to work with stow and fix typo

* feat: expose workflow set function to be used from other scripts

* fix: gamemode script cleanup

* feat: match with gamemode set via gamemode script

* feat: improved workflows

---------

Co-authored-by: Khing <[email protected]>
kRHYME7 added a commit that referenced this pull request Jul 19, 2025
* Workflow script fixes (#887)

* fix: follow symlinks to work with stow and fix typo

* feat: expose workflow set function to be used from other scripts

* fix: gamemode script cleanup

* feat: match with gamemode set via gamemode script

* feat: improved workflows

---------

Co-authored-by: Khing <[email protected]>

* Consistency, cleanup and minor improvements for waybar modules (#883)

* fix: consistency, cleanup and minor improvements for waybar modules

* fix: change case for consistency

* fix: use hyde-shell for commands

* feat: add glyphs for menu to bring consistency and eye candy

* fix: make icons and spacing consistent

* refactor: Porting our shaders to be #version 300 compatible (#894)

* Refactor: Ports Shaders to use #version directive and use version 3.00 as default. This avoids warning on hyprland-git

* fix: add the implementation script

---------

Co-authored-by: Rubin Bhandari <[email protected]>

* feat: clean home directory (#867)

* feat: add more dirs

* feat: add wget

* feat: add python history

* Update env.zsh

* Update env.zsh

* Update env.zsh

---------

Co-authored-by: Khing <[email protected]>

* refactor: chmod and some waybar fixes

* fix: do not use uwsm for hyprlock (#898)

* fix: add `prompt.zsh` to config restore list (#908)

* fix: add `prompt.zsh` to config restore list

* feat: source `${ZDOTDIR}/prompt.zsh` silently

* proper test operator for terminal.zsh

* formatting terminal.zsh

* added optional keybind "?" to append and run with --help.

i am used to running  a cisco switch

* remove -h

* Make OMZ optional (#912)

* feat: make OMZ optional so that other options like zinit can be used

* fix: remove global alias for -h, fix #910

* chore: polish

* fix: use existing variable

* fix: use the correct var

* feat: Add 'hyde-shell version' to get local version

fix feat: hyde-shell --version should return HyDE's current install.sh -r #916

Closes #916

* Use latest flags for vscode and electron (#885)

fix: use latest flags for vscode and electron

Co-authored-by: Khing <[email protected]>

* Find symlinked themes (#924)

fix: find themes that are symlinked

Co-authored-by: Khing <[email protected]>

* Add new hyprlock layout (#874)

* hyprlock layout 

new hyprlock layout similar to greetd login manager

* Update greetd.conf

* fix scaling issue

* Update greetd.conf

* Update greetd.conf

* Update greetd.conf

* add dnd script

* Update keybindings.conf

* Update keybindings.conf

* Delete Configs/.local/lib/hyde/dnd.sh

---------

Co-authored-by: Khing <[email protected]>

* fix(hyprlock): greetd

* feat (hyprlock): greetd.conf with wallbash

* add best fzf aliases ever pt 2 And fish cleanups and bug fixes (#919)

* refactor: fzf functions structure in fish

* fix: duf alias and finilize main fish conf

* update zsh config to include new aliases

* user > userprefs

* refactor: hyde-shell is fork when executing script.

** Added some completions

* fix: swaync

* refactor  (waybar): Full cava module rewrite

Fixes:
- #936
- #935
- #189
- #403

- Also TOOLTIP is now working!!!

- 1 cava process for all clients!

* hesoyam

* fix > [#460 (comment)](#460 (comment)) #943

Remove explicit position

* fix (waybar): prasanthrangan/hyprdots#2154

Fix prasanthrangan/hyprdots#2154

* fix: Correct Brave browser class name in windowrules.conf (#947)

* feat: corrected Brave-browser to brave-browser in windowrules

* fix: Correct Brave browser class name in windowrules.conf

This commit fixes a typo in the window rule for the Brave browser, changing `Brave` to `brave-browser` to ensure proper window management.

* Update README.md

* ci:test dev-rc

* ci:test rc-master

* ci:test rc-master

* ci:test rc-master

* ci:test rc-master

* feat(zsh): Custom plugin.zsh for users to have there own zsh plugin management.

I added some example using zinit

TODO: Add prompt for omz installation

* feat(zsh): added plugin.zsh

* fix(core): stray line

* bumb rc PR

* feat(cava.py): added reload option, added channel and reverse mode.

chore (hypridle): Added systemctl startup for hypridle.

* feat: Add a backend for hyprpaper for wallpaper.sh (#967)

# Pull Request

## Description

This PR adds a backend for hyprpaper in wallpaper.sh, which allows
people to have the splash, note that this requires the user who wants
hyprpaper to install hyprpaper, but it's not an issue.

## Type of change

- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [x] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that would cause existing
functionality to not work as expected)
- [ ] **Documentation update** (non-breaking change; modified files are
limited to the documentations)
- [ ] **Technical debt** (a code change that does not fix a bug or add a
feature but makes something clearer for devs)
- [ ] **Other** (provide details below)

## Checklist

- [x] I have read the
[CONTRIBUTING](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md)
document.
- [x] My code follows the code style of this project.
- [x] My commit message follows the [commit
guidelines](https://github.com/HyDE-Project/HyDE/blob/master/COMMIT_MESSAGE_GUIDELINES.md).
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added a changelog entry.
- [x] I have added necessary comments/documentation to my code.
- [ ] I have added tests to cover my changes.
- [x] I have tested my code locally and it works as expected.
- [ ] All new and existing tests passed.

* feat(cava.py): added reload option, added channel and reverse mode.

* fix ffcd fish funtion  (#973)

fix pos arg in ffcd

* fix pos arg in ffcd #973 followup (#974)

fix pos arg in ffcd

* optimize picker + fuzzy search (#978)

* optimize picker + fuzzy search

* fix and update glyph.db

* opts for emoji*.sh and fix multi select in glyphpicker

---------

Co-authored-by: Khing <[email protected]>

* fix (waybar) :ignore OBS and cava for privacy module

* fix (waybar) :ignore OBS and cava for privacy module

* Added additional args for emoji and glyph pickers

* waybar privacy Do not monitor audio out

* refactor: remove redundant hyde-shell

TODO: make all scripts use

[[ "${HYDE_SHELL_INIT}" -ne 1 ]] && eval "$(hyde-shell init)"

this initiates hyde-shell if and only if it is not yet set.

* feat(waybar): add border and background style groups (#983)

* feat(waybar): add border and background style groups

Add new CSS files for Waybar style groups, including border styles
(solid, dotted, none) and color variants for borders.
Also add transparent background style.

* refactor(waybar): restructure styles directory layout

---------

Co-authored-by: Khing <[email protected]>

* docs for contributions (#964)

* docs for contributions

squash this

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Khing <[email protected]>

* Fix theme import terminal

* Fix gnome-terminal and theme-import (#987)

* Update theme-import command to new Hydectl

* Fix gnome-terminal by removing '' from terminal

So basically if you run gnome-terminal without | tr -d "'", it will try to run 'kitty' instead of kitty which is an invalid command.

* use xargs to clean a string

* Update gnome-terminal

---------

Co-authored-by: Khing <[email protected]>

* Features and fixes for mediaplayer  (#865)

* feat(mediaplayer): Added waybar module for mediaplayer

* feat(mediaplayer): modified mediaplayer to support multiple
players

* feat(mediaplayer): Add env option for players

* fix(mediaplayer): get first player that is player
if there are none then get first player in list

* feat(mediaplayer): Added media controls (next/previous/playpause)

* fix(mediaplayer): escaped & in song metadata

* feat(mediaplayer.py): Made text only show main artist
Tooltip shows all.

* fix(mediaplayer.py): redo algorithm that proportions

* feat(mediaplayer.py): Added env option for artist weight

* fix(mediaplayer): moved all players output to tooltip
except for current

* docs(CONTRIBUTORS): added myself to CONTRIBUTORS.md

* feat(mediaplayer): added player name to tooltip

* fix(mediaplayer.py): Fixed waybar signaling twice
to mediaplayer.py and fixed kill commands for media control

* fix(mediaplayer): add back removed option --player

* fix(mediaplayer): set player_found correctly

* fix(mediaplayer): fix possible IndexError

* feat(mediaplayer): change player when current one
vanishes.

* fix(mediaplayer): Fixed not tracking new players
that appear when user doesn't provide players

* fix(mediaplayer): Skipped a player because it is
a duplicate for the browsers player

* Added Changelog

---------

Co-authored-by: Khing <[email protected]>
Co-authored-by: Khing <[email protected]>

* Try to fix waybar for multi user

* bump

* yup

* Fix: [Bug]: spotify module not working #1002

* feat: General Purpose Mediaplayer

* featxes 🏃‍➡️

* refactor: no redundant hyde-shell sourcing pt2

---------

Co-authored-by: Deepu K Sasidharan <[email protected]>
Co-authored-by: Khing <[email protected]>
Co-authored-by: Rubin Bhandari <[email protected]>
Co-authored-by: Ilya Bogdanov <[email protected]>
Co-authored-by: Mahaveer Gurjar <[email protected]>
Co-authored-by: prime-run <[email protected]>
Co-authored-by: GokuPlay609 <[email protected]>
Co-authored-by: Mircas001 <[email protected]>
Co-authored-by: Harsh Dabas <[email protected]>
Co-authored-by: rawnullbyte <[email protected]>
Co-authored-by: Silvestre Espinoza <[email protected]>
Co-authored-by: Khing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants