claude: remove stray debug print from dates() filter rewriting#4766
Open
Liam-DeVoe wants to merge 1 commit into
Open
claude: remove stray debug print from dates() filter rewriting#4766Liam-DeVoe wants to merge 1 commit into
Liam-DeVoe wants to merge 1 commit into
Conversation
Zac-HD
approved these changes
Jun 14, 2026
Zac-HD
left a comment
Member
There was a problem hiding this comment.
lgtm, but we might as well add the lint rule and open an issue for the bytes warning (assuming it's larger than is convenient to fix here)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude-written description
Removes a stray debug
print(lo, hi)fromDateStrategy.filter, left over from the original filter-rewriting-for-dates change in 6.115.1. It printed to stdout from library code whenever adates()strategy's.filter()was rewritten from apartial(op.lt/le/eq/ge/gt, <date>)predicate.Also adds a
|st.dates|substitution todocs/prolog.rst(used by the new changelog entry), and aRELEASE.rstwith a patch changelog entry.The existing
test_dates_filter_rewritingalready covers the rewrite path; the filter-rewriting test suite passes. (One unrelated pre-existing failure intest_regex_filter_rewriting— aBytesWarningin the internal cache underpython -bb— reproduces on unmodified master.)Self-review note: enabling ruff
T20(flake8-print) forhypothesis/srcwould guard against this class of bug systemically (onlyreporting.pyandextra/cli.pyprint legitimately), but was left out to keep this PR minimal.