This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Create 'math_mutiply' endpoints #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neumannrf
suggested changes
Mar 21, 2019
| integer_list.extend(doubled_list) | ||
| return integer_list | ||
| integer_list.extend(multiplied_list) | ||
| return integer_list |
There was a problem hiding this comment.
A falta de um linha em branco no final deste arquivo está gerando o erro src/math_services.py:22:24: W292 no newline at end of file.
| @@ -7,3 +7,15 @@ def test_double_list(): | |||
| assert ms.double_list([2]) == [4] | |||
| assert ms.double_list([1, 2]) == [2, 4] | |||
| assert ms.double_list([1, 2, 3]) == [2, 4, 6] | |||
|
|
|||
| def test_multiply_list(): | |||
There was a problem hiding this comment.
O flake8 espera encontrar 2 linhas em branco entre uma função e a outra, gerando o erro test/math_test.py:11:1: E302 expected 2 blank lines, found 1.
| assert ms.multiply_list([1, 2], 2) == [2, 4] | ||
| assert ms.multiply_list([1, 2, 3], 0) == [0, 0, 0] | ||
| assert ms.multiply_list([1, 2, 3], 1) == [1, 2, 3] | ||
| assert ms.multiply_list([1, 2, 3], 2) == [2, 4, 6] |
There was a problem hiding this comment.
A falta de um linha em branco no final deste arquivo está gerando o erro test/math_test.py:21:55: W292 no newline at end of file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
math_multiply_20:
-Create 'src/math_services.py'
-Create 'test/math_services.py'
-Modify 'main.py'
Checklist
requirements.txt.external.external.Related Issue
Closes #20
Notes to Reviewer
...