-
Notifications
You must be signed in to change notification settings - Fork 120
Main - Replace Fast Hash system with native hashmaps #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- removes the garbage collector and hash monitor as these are no longer necessary
- no longer necessary with native hashmaps
@@ -1,13 +0,0 @@ | |||
class CfgLocationTypes { | |||
// For use in Fast Hashes ONLY! | |||
class ACRE_FastHashNamespaceDummy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to leave this in for one release if it could effect saved games
need to check capitalization on all hash keys ["ACRE_PRC117F_ID_1"] call acre_sys_prc117f_fnc_getChannelDataInternal ["ACRE_PRC152", "default"] call acre_api_fnc_getPresetData; ["ACRE_PRC152_ID_1"] call acre_api_fnc_getRadioChannel; // item's config case |
This is quite a problem for other mods is it not? There is for example no documented way to get the channel labels except via this function, followed up with |
Yep, code like this will break... But it never was a public API so I guess fair enough. |
I mean the example I posted is very much public api |
I think there is enough complications from this with mod compat and general API use that it should probably be reverted until a better solution is designed or you're willing to break compat. I don't use any public mods that interface with ACRE2 so I was unaware people were directly accessing this data and not utilizing some form of API call that could have adjustments made to maintain compat at the tradeoff of slightly worse perf per call (toLowerANSI on keys, etc) |
We will revert if necessary (#1322 does not make it). |
When merged this pull request will: