Skip to content

Language & choicehint #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Language & choicehint #1298

merged 1 commit into from
Nov 15, 2017

Conversation

azaroth42
Copy link
Member

Closes #755 ; Closes #1194

@azaroth42
Copy link
Member Author

Preview: http://preview.iiif.io/api/language-choicehint/api/presentation/3.0/

Note @glenrobson that the CSS isn't working?

@glenrobson
Copy link
Member

glenrobson commented Nov 11, 2017

Hi Rob,

If you set

- ROOT_INSTALL="false"

to false rather than true in:

https://github.com/IIIF/api/blob/language-choicehint/.travis.yml

the css will start working again. Set ROOT_INSTALL to true if I've setup a subdomain for it like http://prezi3.iiif.io/.

Note if your going to merge this into prezi3 branch then ROOT_INSTALL should be left as true.

Cheers

Glen

Copy link
Member

@mikeapp mikeapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@tomcrane tomcrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zimeon zimeon merged commit eab81c5 into prezi3 Nov 15, 2017
@zimeon zimeon deleted the language-choicehint branch November 15, 2017 17:12
@zimeon zimeon removed the review label Nov 15, 2017
@azaroth42 azaroth42 mentioned this pull request Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants