Skip to content

description -> summary (#1242) #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2017
Merged

description -> summary (#1242) #1326

merged 2 commits into from
Nov 29, 2017

Conversation

azaroth42
Copy link
Member

Closes #1242 ; replaces description with summary throughout.

@azaroth42 azaroth42 added this to the Presentation 3.0 milestone Nov 27, 2017
@azaroth42 azaroth42 requested a review from a team November 27, 2017 19:02
@azaroth42
Copy link
Member Author

Failure is an unrelated link checker 4xx/5xx. ( #1329 )

@zimeon
Copy link
Member

zimeon commented Nov 27, 2017

Maybe I was hasty with review --- the example shows ONE summary not in an array. Do we want to allow more than one, I don't see why that is helpful but if we do allow multiple then perhaps we need client guidelines as to what to do (concatenate?)

@azaroth42
Copy link
Member Author

Hasty with comment? It's a language map, so multiple values would be per language key in the map :)

@zimeon
Copy link
Member

zimeon commented Nov 27, 2017

Then the text is unclear -- I read "one or more summarys" to mean "one or more summary properties, each of which is a language map"

@zimeon
Copy link
Member

zimeon commented Nov 27, 2017

This ties with a second comment I wondered about -- should we avoid pluralizing property names by instead saying "summary properties" which also makes it clear which thing has a given cardinality.

@azaroth42
Copy link
Member Author

We'll have the same issue with all languageMap fields ... so should create a new issue to resolve consistently?

@tomcrane tomcrane merged commit 1b224cc into prezi3 Nov 29, 2017
@azaroth42 azaroth42 removed the review label Nov 29, 2017
@tomcrane tomcrane deleted the 1242-description-summary branch November 29, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants