Skip to content

[ENHANCEMENT] Fix show for AbstractBlockSparseArray with unconvential type parameter orderings #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mtfishman opened this issue Feb 28, 2025 · 0 comments · Fixed by #65
Assignees
Labels
enhancement New feature or request

Comments

@mtfishman
Copy link
Member

I noticed that the show method introduced in #42 assumes the AbstractBlockSparseArray being printed has a certain type parameter ordering when printing the type, i.e. it assumes it is {eltype,ndims,blocktype,...}. We should constrain that part of the code logic to BlockSparseArray, and for other AbstractBlockSparseArrays print the entire type by default and expect them to define their own show method if they want more compact printing.

@mtfishman mtfishman added the enhancement New feature or request label Feb 28, 2025
@mtfishman mtfishman self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant