Skip to content

Fix generic show for block sparse arrays #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2025
Merged

Conversation

mtfishman
Copy link
Member

Fixes #63, using the same code pattern that was used in ITensor/NamedDimsArrays.jl#48.

The show methods also have to be updated to reflect the changes @lkdvos made in ITensor/SparseArraysBase.jl#31, but this is orthogonal to that issue since this PR is only about how the types are printed, not how the unstored values are printed.

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (bfe3820) to head (f5c626d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...stractblocksparsearray/abstractblocksparsearray.jl 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   75.49%   74.59%   -0.91%     
==========================================
  Files          29       29              
  Lines        1106     1106              
==========================================
- Hits          835      825      -10     
- Misses        271      281      +10     
Flag Coverage Δ
docs 24.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos
Copy link
Contributor

lkdvos commented Mar 2, 2025

Do you want me to add that change to this PR as well?

@mtfishman
Copy link
Member Author

Do you want me to add that change to this PR as well?

I'll merge this and we can do that in a followup PR, I think that would require other updates for SparseArraysBase.jl v0.3 anyway.

@mtfishman mtfishman merged commit 4fae77f into main Mar 2, 2025
11 of 12 checks passed
@mtfishman mtfishman deleted the fix_generic_show branch March 2, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Fix show for AbstractBlockSparseArray with unconvential type parameter orderings
2 participants