Skip to content

Define isstored for SubArray #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Define isstored for SubArray #44

merged 3 commits into from
Mar 6, 2025

Conversation

mtfishman
Copy link
Member

This generalizes a definition originally made in ITensor/BlockSparseArrays.jl#74, with the goal of fixing ITensor/BlockSparseArrays.jl#73.

@lkdvos ideally this code would handle things like linear indexing but that system is being rewritten in #39 so for now I'm just following the style of how other isstored functions are defined.

@mtfishman mtfishman requested a review from lkdvos March 5, 2025 19:53
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.49%. Comparing base (d741b7f) to head (5d45797).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   71.36%   71.49%   +0.13%     
==========================================
  Files           7        7              
  Lines         433      435       +2     
==========================================
+ Hits          309      311       +2     
  Misses        124      124              
Flag Coverage Δ
docs 37.26% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
Copy link
Member Author

I missed that I actually had made basically the same definition of isstored for SubArray, but it was restricted to sparse arrays, so I just defined a similar definition for all arrays. @lkdvos let me know what you think (I'm leaving the sparse array definition since it is in an eval loop anyway).

Probably we can make more of the sparse array definitions for wrappers more general, but I'd prefer to leave that for a future PR since I think that is more involved.

@mtfishman mtfishman merged commit 4e94eea into main Mar 6, 2025
14 checks passed
@mtfishman mtfishman deleted the isstored_subarray branch March 6, 2025 16:11
@mtfishman mtfishman mentioned this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants