Remove ios native dependencies #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
suggested changes
Feb 8, 2017
TsvetanMilanov
force-pushed
the
milanov/remove-ios-native-dependencies
branch
from
88d7db5 to
5d8d3d4
Compare
TsvetanMilanov
force-pushed
the
milanov/remove-ios-native-dependencies
branch
2 times, most recently
from
5f6b1fd to
17a6128
Compare
We need to remove our native dependencies - ref and ffi because they are casuing problems with each version of NodeJS which has new version of V8 in it. We are using ref and ffi to communicate with iTunes and execute fs and application management operations on iOS devices. This operations are moved in new dependency - device-lib. The device lib has JavaScript wrapper which we use in the CLI. Everything in the ios device file system and ios device application manager is replaced with the exposed methods from the device lib.
TsvetanMilanov
force-pushed
the
milanov/remove-ios-native-dependencies
branch
from
17a6128 to
b9d9d6e
Compare
TsvetanMilanov
force-pushed
the
milanov/remove-ios-native-dependencies
branch
3 times, most recently
from
d384887 to
77c49e8
Compare
TsvetanMilanov
force-pushed
the
milanov/remove-ios-native-dependencies
branch
from
77c49e8 to
de46f0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove our native dependencies - ref and ffi because they are casuing problems with each version of NodeJS which has new version of V8 in it. We are using ref and ffi to communicate with iTunes and execute fs and application management operations on iOS devices. This operations are moved in new dependency - device-lib. The device lib has JavaScript wrapper which we use in the CLI. Everything in the ios device file system and ios device application manager is replaced with the exposed methods from the device lib.
Common lib reference: telerik/mobile-cli-lib#889