Skip to content

Micro optimizations #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Micro optimizations #321

wants to merge 6 commits into from

Conversation

lippserd
Copy link
Member

No description provided.

@julianbrost
Copy link
Contributor

@lippserd What's the future plan for this PR?

@lippserd
Copy link
Member Author

@lippserd What's the future plan for this PR?

Honestly, I don't know yet but I asked @Al2Klimov to test whether this PR does anything in terms of performance, cpu and memory usage.

@Al2Klimov
Copy link
Member

TODO

  • throw away everything not to be merged anyway (e.g. exit after config sync)
  • make CI/CD happy

@Al2Klimov
Copy link
Member

Tip: git push -f commit by commit sleeping 10s inbetween, so we see whose commits broke the CI/CD.

@lippserd
Copy link
Member Author

Tip: git push -f commit by commit sleeping 10s inbetween, so we see whose commits broke the CI/CD.

The new types from your commits don’t have the database interfaces implemented and thus the delete fails if I remember correctly.

@lippserd lippserd changed the title Performance Micro optimizations Nov 12, 2021
@lippserd lippserd removed their assignment Feb 24, 2022
@oxzi
Copy link
Member

oxzi commented Jun 12, 2025

In order to cleanup relicts, I came across this PR. After skimming the changes, I found nothing to categorize as very important. Furthermore, nothing merges anymore and some code went to the IGL.

Would you like to rebase or recreate some parts of this or would you prefer closing this issue, @lippserd?

@lippserd
Copy link
Member Author

In order to cleanup relicts, I came across this PR. After skimming the changes, I found nothing to categorize as very important. Furthermore, nothing merges anymore and some code went to the IGL.

Would you like to rebase or recreate some parts of this or would you prefer closing this issue, @lippserd?

I will close it. A performance analysis regarding using a different JSON lib and timestamp and checksum refactoring might be interesting, but that's something for when we run out of tasks 😆.

@lippserd lippserd closed this Jun 17, 2025
@lippserd lippserd deleted the performance branch June 17, 2025 06:51
@julianbrost
Copy link
Contributor

using a different JSON lib

encoding/json/v2? 👀 (Would probably make sense to see what happens within the Go standard library before evaluating external libraries.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants