-
Notifications
You must be signed in to change notification settings - Fork 22
Micro optimizations #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro optimizations #321
Conversation
@lippserd What's the future plan for this PR? |
Honestly, I don't know yet but I asked @Al2Klimov to test whether this PR does anything in terms of performance, cpu and memory usage. |
TODO
|
Tip: git push -f commit by commit sleeping 10s inbetween, so we see whose commits broke the CI/CD. |
The new types from your commits don’t have the database interfaces implemented and thus the delete fails if I remember correctly. |
In order to cleanup relicts, I came across this PR. After skimming the changes, I found nothing to categorize as very important. Furthermore, nothing merges anymore and some code went to the IGL. Would you like to rebase or recreate some parts of this or would you prefer closing this issue, @lippserd? |
I will close it. A performance analysis regarding using a different JSON lib and timestamp and checksum refactoring might be interesting, but that's something for when we run out of tasks 😆. |
|
No description provided.