Drop some superfluous Redis -> DB value mappings

[yhabteab]

This PR is basically the same as Icinga/icinga2#10452 and removes the now superfluous Redis -> DB value mappings, and also makes the {host,service}_state.is_acknowledged column a simple boolenum and introduces a new is_sticky_acknowledgement column to indicate sticky acknowledgements.

Requires

• IcingaDB: Make Redis & DB values consistent icinga2#10452

[oxzi]

First, thanks for this PR. In general, it looks good.

I went over the code - and its counterpart in Icinga 2 - multiple times and added some small comments.

Furthermore, I did some testing in a playground setup and clicking a non-sticky and a sticky in Icinga DB Web resulted in the expected data within the relation database.

MariaDB [icingadb]> select comment.text, is_acknowledged, is_sticky_acknowledgement  from service_state join comment on service_state.acknowledgement_comment_id = comment.id where is_acknowledged = 'y'\G
*************************** 1. row ***************************
                     text: F
          is_acknowledged: y
is_sticky_acknowledgement: n
*************************** 2. row ***************************
                     text: sticky F
          is_acknowledged: y
is_sticky_acknowledgement: y
2 rows in set (0.004 sec)

[oxzi]

Looks good so far, thanks!

After this PR's counterpart against Icinga 2 was properly reviewed and merged, I would take another look. Consider this a soft approve.

However, my comment regarding the different column order in PostgreSQL remains; #964 (comment). I would like to hear some opinions if we should resolve this or treat this as an annoyance to be ignored.

[yhabteab]

That was my final push :). So please have another look again!

[oxzi]

LGTM.

Went over the code another time, tested it together with Icinga 2 based on your other PR, tested updated icingadb-migrate command. Nothing fell apart. Thanks!